Switch to CPU-side stroke encoding #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't use GPU-side signed distance field rendering for strokes, but rather expand them on the CPU (using kurbo) during encoding, then render using fill. This is a significant performance regression, but is on the critical path path for multisampled path rendering and stroke rework (#303).
|
One cleanup that probably should be considered is getting rid of the |
dfrg
approved these changes
Oct 5, 2023
There was a problem hiding this comment.
Looks great! Thanks for doing the work to keep stroked glyph outlines functional.
Deferring is_fill removal makes sense for now. We’ll want to update path encoding to match whatever we do for linebender/kurbo#303 anyway so let’s do the work then.
|
Thanks for the review. Agree on the is_fill question, I was thinking about that on my morning run. I'll merge the peniko PR then update this to point there. |
Now that peniko#14 is merged, let's point to that rather than a PR in review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't use GPU-side signed distance field rendering for strokes, but rather expand them on the CPU (using kurbo) during encoding, then render using fill.
This is a significant performance regression, but is on the critical path path for multisampled path rendering and stroke rework (#303).